Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(fe): bump webpack-related packages to v5 #30528

Merged
merged 1 commit into from
Oct 7, 2024
Merged

chore(fe): bump webpack-related packages to v5 #30528

merged 1 commit into from
Oct 7, 2024
+598 −448

Conversation

hainenber
Copy link
Contributor

chore(fe): bump webpack-related package to v5

SUMMARY

Bump webpack-related packages (webpack-cli, webpack-dev-server` and co.) to latest version, i.e. v5.
Bump webpack to v5.95.0 to utilize a performance gain.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Run npm ci && npm run dev-server
image
image

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hainenber
chore(fe): bump webpack-related package to v5
fff16b9 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber hainenber changed the title chore(fe): bump webpack-related package to v5 chore(fe): bump webpack-related packages to v5 Oct 5, 2024
@dosubot dosubot bot added the change:frontend Requires changing the frontend label Oct 5, 2024
@michael-s-molina michael-s-molina merged commit 2e88759 into apache:master Oct 7, 2024
37 of 39 checks passed
@michael-s-molina
Copy link
Member

🙏🏼

@michael-s-molina michael-s-molina added review:checkpoint Last PR reviewed during the daily review standup and removed review:checkpoint Last PR reviewed during the daily review standup labels Oct 7, 2024
@justinpark
Copy link
Member

@hainenber I have confirmed that local changes made in the dev-server after this commit are not being updated live. Please run npm run dev-server, make a simple frontend change, and check if the updates are reflected on localhost:9000

@hainenber
Copy link
Contributor Author

Double confirmed from my side. I'll push out PR to fix this. Thanks for catching this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees
No one assigned
Labels
change:frontend Requires changing the frontend dependencies:npm embedded size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hainenber @michael-s-molina @justinpark